-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Event_to_sketch in api #692
Conversation
google#691 Not yet ready to merge
Ok there is still an issue seems the ID returned is not the id from the event. Not sure why |
So the return json is: {
"meta": {},
"objects": [
{
"color": "7C79F3",
"created_at": "Tue, 12 Jun 2018 08:27:56 -0000",
"deleted": null,
"description": "internal timeline for user-created events",
"id": 18,
"name": "sketch specific timeline",
"searchindex": {
"created_at": "Tue, 12 Jun 2018 08:27:52 -0000",
"deleted": null,
"description": "internal timeline for user-created events",
"id": 17,
"index_name": "cd0f4c15c00417d44c7e47414598a23b",
"name": "sketch specific timeline",
"status": [
{
"created_at": "Wed, 31 Oct 2018 06:30:41 -0000",
"id": 145,
"status": "ready",
"updated_at": "Wed, 31 Oct 2018 06:30:41 -0000"
}
],
"updated_at": "Tue, 12 Jun 2018 08:27:52 -0000"
},
"status": [
{
"created_at": "Tue, 12 Jun 2018 11:03:41 -0000",
"id": 17,
"status": "new",
"updated_at": "Tue, 12 Jun 2018 11:03:41 -0000"
}
],
"updated_at": "Tue, 12 Jun 2018 08:27:56 -0000"
}
]
}
|
IMHO ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small nit on the docstring. I'll merge when updated.
Co-Authored-By: deralexxx <deralexxx@users.noreply.github.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@berggren you need to make a author consent as far as I can see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CLS bot is broken. deralexxx has signed the CLA. |
#691
Not yet ready to merge, maybe @berggren has opinion on the PR
e.g. do we need a unit test as well?