Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the emoji library to include helper text #762

Merged
merged 6 commits into from
Jan 2, 2019

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Jan 2, 2019

Adding more structure to the emoji lib, adding helper text.

This is the first step into making the emoji library more integrated into the UI. Next steps would be to add a helper text as soon as you hover over an emoji in the UI and adding an easier filter in the UI to filter for emojis.

Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now when we add some simple logic to this one, can I ask for a test? :)

@kiddinn
Copy link
Contributor Author

kiddinn commented Jan 2, 2019

done, tests added.

@kiddinn kiddinn requested a review from berggren January 2, 2019 20:00
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit 64e7f06 into google:master Jan 2, 2019
@kiddinn kiddinn deleted the emojis_for_life branch January 3, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants