Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor change in import. #808

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Minor change in import. #808

merged 1 commit into from
Jan 29, 2019

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Jan 29, 2019 •
edited
Loading

Minor change, moving from basestring to str, since basestring contains both unicode and str, and it is not needed to decode if the string is already unicode

berggren
berggren approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit 9b7e0fd into google:master Jan 29, 2019
@kiddinn kiddinn deleted the foobug branch January 30, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiddinn @berggren