Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated .pylintrc and changes for linter #855 #856

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Updated .pylintrc and changes for linter #855 #856

merged 2 commits into from
Apr 2, 2019

Conversation

joachimmetz
Copy link
Member

  • removed code flagged as useless-super-delegation
  • changed code flagged as broad-except
  • additional overrides

@joachimmetz joachimmetz requested a review from berggren March 24, 2019 16:46
@joachimmetz joachimmetz mentioned this pull request Mar 24, 2019
Closed
4 tasks
@joachimmetz joachimmetz mentioned this pull request Apr 1, 2019
Closed
10 tasks
@joachimmetz joachimmetz force-pushed the pylint branch 4 times, most recently from 1e34b82 to 1503667 Compare April 1, 2019 19:52
@joachimmetz
Copy link
Member Author

@berggren please have a look, I've switched to use GIFT PPA packages

berggren
berggren approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit 3afe0f4 into google:master Apr 2, 2019
@joachimmetz joachimmetz deleted the pylint branch April 2, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@berggren berggren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joachimmetz @berggren