Markdown stories #866
Merged
Markdown stories #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiddinn
reviewed
Apr 12, 2019
timesketch/views/spa.py
Outdated
| @login_required | ||
| # pylint: disable=unused-argument | ||
| def redirect_view(sketch_id, view_id): | ||
| """Generates the template. |
There was a problem hiding this comment.
this feels a bit weird....
the function is called redirect_view but the docstring says generate the template and then all it does is return a redirect call.. so the function name and content seem to match but the docstring sounds a bit weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Markdown support for the story feature in the new frontend code. This replaces the old HTML based stories and add the benefit of being data driven. This will enable API support for creating stories.
Part of: #867