Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUS2019-CTF Colab #872

Merged
merged 6 commits into from
Apr 26, 2019
Merged

MUS2019-CTF Colab #872

merged 6 commits into from
Apr 26, 2019

Conversation

obsidianforensics
Copy link
Contributor

No description provided.

@berggren berggren requested a review from kiddinn April 24, 2019 09:38
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only very minor comments, otherwise LGTM

notebooks/MUS2019_CTF.ipynb Outdated Show resolved Hide resolved
notebooks/MUS2019_CTF.ipynb Outdated Show resolved Hide resolved
notebooks/MUS2019_CTF.ipynb Show resolved Hide resolved
"cell_type": "code",
"source": [
"# The ActiveTimeBias is in minutes, so divide by -60 (I don't know why it's stored negative): \n",
"420 / -60"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although this is a bit more complicated text... should we do this more "programmatically" ? food for thought... something like:

time_string = list(set(ts_results.message))[0]
_, _, data_string = time_string.partition(']')
data = {}
items = data_string.split(':')
key = items[0].strip()

for line in items[1:-1]:
  words = line.split()
  data[key] = ' '.join(words[:-1])
  key = words[-1]
data[key] = items[-1]

print('The UTC offset is: {0:d}'.format(int(data.get('ActiveTimeBias', '0')) / int(data.get('DaylightBias', '1'))))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep it simpler for the target audience. The notebook is supposed to show a "live" investigation, and writing that much code for a small one-time operation seems like overkill to me.

I also think it'd be good to take another look at how plaso parses these out (separate entries per key, rather than all into one string).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... agree... but maybe change the text a bit to show or talk about where those numbers come from...

@obsidianforensics
Copy link
Contributor Author

PTAL

Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

notebooks/MUS2019_CTF.ipynb Show resolved Hide resolved
"cell_type": "code",
"source": [
"# The ActiveTimeBias is in minutes, so divide by -60 (I don't know why it's stored negative): \n",
"420 / -60"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... agree... but maybe change the text a bit to show or talk about where those numbers come from...

@kiddinn kiddinn merged commit 33945f3 into google:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants