-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUS2019-CTF Colab #872
MUS2019-CTF Colab #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only very minor comments, otherwise LGTM
"cell_type": "code", | ||
"source": [ | ||
"# The ActiveTimeBias is in minutes, so divide by -60 (I don't know why it's stored negative): \n", | ||
"420 / -60" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although this is a bit more complicated text... should we do this more "programmatically" ? food for thought... something like:
time_string = list(set(ts_results.message))[0]
_, _, data_string = time_string.partition(']')
data = {}
items = data_string.split(':')
key = items[0].strip()
for line in items[1:-1]:
words = line.split()
data[key] = ' '.join(words[:-1])
key = words[-1]
data[key] = items[-1]
print('The UTC offset is: {0:d}'.format(int(data.get('ActiveTimeBias', '0')) / int(data.get('DaylightBias', '1'))))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep it simpler for the target audience. The notebook is supposed to show a "live" investigation, and writing that much code for a small one-time operation seems like overkill to me.
I also think it'd be good to take another look at how plaso parses these out (separate entries per key, rather than all into one string).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok... agree... but maybe change the text a bit to show or talk about where those numbers come from...
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
"cell_type": "code", | ||
"source": [ | ||
"# The ActiveTimeBias is in minutes, so divide by -60 (I don't know why it's stored negative): \n", | ||
"420 / -60" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok... agree... but maybe change the text a bit to show or talk about where those numbers come from...
No description provided.