Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Sketch object to DB before setting ACL #897

Merged
merged 1 commit into from
May 28, 2019
Merged

Commit Sketch object to DB before setting ACL #897

merged 1 commit into from
May 28, 2019

Conversation

berggren
Copy link
Contributor

Addresses #896 - Commit Sketch to DB before setting ACL.

@berggren berggren requested a review from tomchop May 28, 2019 07:54
@berggren berggren self-assigned this May 28, 2019
@berggren berggren added the Bug label May 28, 2019
tomchop
tomchop approved these changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit e7659f1 into master May 28, 2019
@berggren berggren deleted the sql-fix branch May 28, 2019 08:12
@berggren berggren mentioned this pull request May 28, 2019
Closed
@berggren
Copy link
Contributor Author

related #886

@ptitdoc ptitdoc mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchop tomchop tomchop approved these changes

Assignees

@berggren berggren

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berggren @tomchop