Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable sketch summary #910

Merged
merged 5 commits into from
Jul 5, 2019
Merged

Editable sketch summary #910

merged 5 commits into from
Jul 5, 2019

Conversation

berggren
Copy link
Contributor

This PR makes the sketch title and description editable in place using contenteditable in the new UI.

@berggren berggren added the UI/UX label Jun 13, 2019
@berggren berggren requested a review from kiddinn June 13, 2019 12:10
@berggren berggren self-assigned this Jun 13, 2019
@kiddinn
Copy link
Contributor

kiddinn commented Jun 14, 2019

I see the tests are failing...

r
    force_external=external)
  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/werkzeug/routing.py", line 1776, in build
    raise BuildError(endpoint, values, method, self)
BuildError: Could not build url for endpoint u'user_views.login'. Did you mean u'spa_views.overview' instead?

could you first make sure all tests are successfully running, and then I Can review?

@berggren
Copy link
Contributor Author

berggren commented Jul 2, 2019

Tests pass. @kiddinn PTAL

kiddinn
kiddinn approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiddinn kiddinn merged commit 361e61f into master Jul 5, 2019
@kiddinn kiddinn deleted the editable-sketch-summary branch July 5, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiddinn kiddinn kiddinn approved these changes

Assignees

@berggren berggren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berggren @kiddinn