Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP servicekey analyzer for stackdriver logs #918

Merged
merged 11 commits into from
Jul 5, 2019
Merged

GCP servicekey analyzer for stackdriver logs #918

merged 11 commits into from
Jul 5, 2019

Conversation

pstirparo
Copy link

Gcp servicekey analyzer for stackdriver logs, as produced by dftimewolf collector (https://github.com/log2timeline/dftimewolf/blob/master/dftimewolf/lib/collectors/stackdriver.py)

timesketch/lib/analyzers/gcp_servicekey.py Outdated Show resolved Hide resolved
timesketch/lib/analyzers/gcp_servicekey.py Outdated Show resolved Hide resolved
@berggren berggren changed the title Gcp servicekey analyzer for stackdriver logs GCP servicekey analyzer for stackdriver logs Jul 2, 2019
@berggren berggren self-requested a review July 2, 2019 14:07
@berggren berggren self-assigned this Jul 2, 2019
berggren
berggren previously approved these changes Jul 2, 2019
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

berggren
berggren previously approved these changes Jul 2, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@kiddinn kiddinn merged commit 6019230 into google:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants