Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestomp #942

Merged
merged 21 commits into from
Nov 12, 2019
Merged

Timestomp #942

merged 21 commits into from
Nov 12, 2019

Conversation

fooris
Copy link
Contributor

@fooris fooris commented Aug 7, 2019

@berggren

draft implementation for naive timestomp analyzer

@fooris fooris marked this pull request as ready for review August 9, 2019 11:21
@fooris
Copy link
Contributor Author

fooris commented Aug 12, 2019

Still needs tests

@kiddinn
Copy link
Contributor

kiddinn commented Aug 15, 2019

Is this ready for a review?

@fooris
Copy link
Contributor Author

fooris commented Aug 29, 2019

I added some tests, I think it is ready for review now

@berggren berggren self-requested a review September 16, 2019 19:12
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments. @fooris PTAL

timesketch/lib/analyzers/timestomp.py Outdated Show resolved Hide resolved
timesketch/lib/analyzers/timestomp.py Outdated Show resolved Hide resolved
timesketch/lib/analyzers/timestomp.py Outdated Show resolved Hide resolved
timesketch/lib/analyzers/timestomp.py Outdated Show resolved Hide resolved
timesketch/lib/analyzers/timestomp.py Outdated Show resolved Hide resolved
@berggren
Copy link
Contributor

@fooris PTAL

@kiddinn
Copy link
Contributor

kiddinn commented Oct 19, 2019

gentle ping, what is the status of this?

@fooris
Copy link
Contributor Author

fooris commented Oct 23, 2019

Hi, sorry have been very busy. Will try to get it done this weekend.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@fooris
Copy link
Contributor Author

fooris commented Oct 24, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@fooris fooris requested a review from berggren October 30, 2019 13:39
@fooris
Copy link
Contributor Author

fooris commented Nov 12, 2019

Looks good, some comments. @fooris PTAL

Done. :-)

Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit c7704be into google:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants