-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Example Notebooks #1195
Added Example Notebooks #1195
Conversation
Added a new class named ConvTranspose() to create ConvTranspose layers.
With reference to [this discussion thread](https://gitter.im/trax-ml/community?at=5f8d24693d172d78b383d799)
With reference to this [discussion](https://gitter.im/trax-ml/community?at=5f8d24693d172d78b383d799)
Hi @SauravMaheshkar - One quick request, can you add the following preamble (as a separate code block) to the notebook? Thanks
|
Done @afrozenator |
Another request, can you change the README.md to point the earlier added ipynb's locations to the TRAX locations? Thanks a lot for these notebooks! |
I've added them to the README.md of this branch only. The links are the would be links of the TRAX repository (trax/blob/master/examples/trax-data-Explained.ipynb, ....) |
One more tiny request - Can you rebase to head? I'm having difficulty pulling this PR in because when you created this the examples/ folder didn't exist internally -- I guess this will get solved by being on master's head. I will investigate if there is any other way to pull this in. |
@afrozenator I added everything to my master branch. (deconvolution.py, README changes, examples/ folder). Should I open another PR from my master and close this PR? |
Sorry, GitHub isn't my strongest suit -- but it basically seems like on trax/master we have a README.md in examples/ that was deleted by rebasing (because now Github is saving this branch has conflicts that need resolving). You maybe right - let's try it in a new PRs (on top of current TRAX head) just adding the notebooks in one PR and the deconv in another Thanks - I'll let you close this. |
(Or maybe just put everything into a single PR, less work for everyone) Sorry for the back and forth, appreciate your patience! |
Done : #1232 |
Closing this, since we're iterating on #1232 |
This is in reference to the following gitter discussions: