Remove implicit object from the base class
#1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HarshCasper - Thanks for sending the PR, nice work! Can I request you to revert the files under trax/tf_numpy -- It's in the process of being moved to its own repo -- so we're not accepting PRs there at the moment. |
afrozenator
added
ready to pull
|
Thanks for the kind words @afrozenator I have reverted all the files under |
|
Thanks @HarshCasper - working on getting this in now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request removes implicit
objectfrom the Base Class.The Issue seems to be very minor but it improves the readability of the Code and since Python 3 inserts it for us behind the scenes, I suggested that its best remove them up.
I'm a First-Time Contributor to Google Open-Source so it would be helpful for me understanding how PR workflow works and help me step up in future contributions as well.