Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to earliest due milestone #245

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Default to earliest due milestone #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion pkg/site/kanban.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@ func milestoneChoices(results []*triage.RuleResult, milestoneID int) (*github.Mi
// Only auto-select a milestone if all issues are within a milestone
if milestoneID == -1 {
if len(milestones) > 0 && notInMilestone == 0 {
milestoneID = milestones[0].GetNumber()
if c := currentMilestone(milestones); c != nil {
milestoneID = c.GetNumber()
} else {
milestoneID = milestones[0].GetNumber()
}
} else {
milestoneID = 0 // all
}
Expand Down Expand Up @@ -313,3 +317,19 @@ func milestoneChoices(results []*triage.RuleResult, milestoneID int) (*github.Mi

return chosen, choices
}

func currentMilestone(milestones []*github.Milestone) *github.Milestone {
var curr *github.Milestone
today := time.Now()
for _, m := range milestones {
if m.GetDueOn().Before(today) {
continue
}
if curr == nil {
curr = m
} else if m.GetDueOn().Before(curr.GetDueOn()) {
curr = m
}
}
return curr
}