Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ctclone for 'coerced get-entries' in Let's Encrypt and other CT Logs #1055

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Adapt ctclone for 'coerced get-entries' in Let's Encrypt and other CT Logs #1055

merged 4 commits into from
Mar 20, 2024

Commits on Mar 19, 2024

  1. Update Bulk download method description as a result of the commit b7f… 

    …2467.
    @tired-engineer
    tired-engineer committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7309264 View commit details
    Browse the repository at this point in the history

  2. Return the number of fetched entries by fetchWorker to allow upcoming… 

    … implementation of various behaviours on incomplete batches.
    @tired-engineer
    tired-engineer committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8f2e42f View commit details
    Browse the repository at this point in the history

  3. Introduce an 'alignment' call to CT log to cover the coerced page case.

    @tired-engineer
    tired-engineer committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f9ed680 View commit details
    Browse the repository at this point in the history

  4. Snap alignment before kicking off threads 

    This keeps the logic cleaner inside the goroutines doing the parallel downloads, and means that a one-off alignment fix can be realized without crashing the process. The clone tool will still crash if alignment is needed after the initial batch or two, but that's outside the scope of this change.
    @mhutchinson @tired-engineer
    mhutchinson authored and tired-engineer committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1ff05b5 View commit details
    Browse the repository at this point in the history