You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2787 migrated Trillian to use klog. At the time, golangci-lint's staticcheck did not know that klog.Exit/Fatal would not return and so threw false +ve lint checks during presubmit which were suppressed with nolint comments.
A fix has been sent which enlightens the lint checker, so once that fix has made it into a golangci-lint release (v1.48.0 did not contain it) we should bump the version used in our presubmits and remove the //nolint comments in experimental/batchmap/cmd/verify/verify.go
The text was updated successfully, but these errors were encountered:
#2787 migrated Trillian to use
klog
. At the time,golangci-lint
'sstaticcheck
did not know thatklog.Exit/Fatal
would not return and so threw false +ve lint checks during presubmit which were suppressed withnolint
comments.A fix has been sent which enlightens the lint checker, so once that fix has made it into a
golangci-lint
release (v1.48.0 did not contain it) we should bump the version used in our presubmits and remove the//nolint
comments in experimental/batchmap/cmd/verify/verify.goThe text was updated successfully, but these errors were encountered: