-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from glog to klog #2787
Switch from glog to klog #2787
Conversation
This should pull in latest go-licenses once this is merged: google/go-licenses#138 |
39f5223
to
a30443b
Compare
/gcbrun I've just rebased this to fix conflicts in the go.mod file |
This is currently failing presubmit checks because
|
I've got #2791 to update to the latest linter, but it doesn't fix this problem. https://github.com/dominikh/go-tools/blob/v0.3.3/go/ir/exits.go#L100 - looks like more work is required upstream in the staticcheck library to detect the |
a30443b
to
c038dc4
Compare
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
c038dc4
to
548435c
Compare
/gcbrun |
I've rebased/jimmied onto |
Added #2801 to track removing the |
Please see the following explanation of the reasons for klog vs. glog: https://github.com/kubernetes/klog#why-was-klog-created