Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from glog to klog #962

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Switch from glog to klog #962

merged 3 commits into from
Aug 20, 2022

Conversation

jdolitsky
Copy link
Contributor

Please see the following explanation of the reasons for klog vs. glog: https://github.com/kubernetes/klog#why-was-klog-created

@jdolitsky jdolitsky requested a review from a team as a code owner July 29, 2022 18:54
@jdolitsky jdolitsky requested review from zkpjedi and removed request for a team July 29, 2022 18:54
@jdolitsky
Copy link
Contributor Author

This should pull in latest trillian once this is merged: google/trillian#2787

@zkpjedi
Copy link

zkpjedi commented Jul 29, 2022

/gcbrun

jdolitsky and others added 2 commits August 19, 2022 12:20
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@AlCutter
Copy link
Member

/gcbrun

@AlCutter
Copy link
Member

/gcbrun

Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkpjedi Would you mind reviewing my two tiny extra commits on Josh's PR?

@dlorenc
Copy link

dlorenc commented Aug 20, 2022

Not that mine counts for anything, lgtm :)

@zkpjedi zkpjedi merged commit 6203bd2 into google:master Aug 20, 2022
@zkpjedi
Copy link

zkpjedi commented Aug 20, 2022

Thanks Al!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants