Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate Log Update Failures in AddSequencedLeaves #1544

Merged
merged 4 commits into from
May 26, 2022

Conversation

therealdrake
Copy link
Contributor

AddSequencedLeaves in the log client previously did not evaluate the response proto. Adding some fail case checking and logging.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1544 (735f1dd) into master (5e12fb3) will increase coverage by 1.12%.
The diff coverage is 0.00%.

❗ Current head 735f1dd differs from pull request most recent head 6458c64. Consider uploading reports for the commit 6458c64 to get more accurate results

@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
+ Coverage   66.12%   67.24%   +1.12%     
==========================================
  Files         103      105       +2     
  Lines        7013     8586    +1573     
==========================================
+ Hits         4637     5774    +1137     
- Misses       1884     2230     +346     
- Partials      492      582      +90     
Impacted Files Coverage Δ
client/log_client.go 68.89% <0.00%> (-9.40%) ⬇️
storage/mysql/queue.go 43.13% <0.00%> (-19.61%) ⬇️
trees/optype_string.go 16.66% <0.00%> (-16.67%) ⬇️
quota/group_string.go 22.22% <0.00%> (-11.12%) ⬇️
quota/kind_string.go 25.00% <0.00%> (-8.34%) ⬇️
client/log_verifier.go 71.92% <0.00%> (-8.08%) ⬇️
quota/quota.go 85.71% <0.00%> (-5.96%) ⬇️
crypto/keys/handlers.go 83.33% <0.00%> (-4.91%) ⬇️
storage/mysql/tree_storage.go 49.26% <0.00%> (-4.25%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b25e4...6458c64. Read the comment docs.

client/log_client.go Outdated Show resolved Hide resolved
client/log_client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this much needed change.
Just a few suggestions on using the status library for easier handling of the status

I'll also loop in @Martin2112 for his approval.

@AlCutter
Copy link
Member

AlCutter commented May 2, 2019

wdyt @Martin2112 ?

Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@Martin2112 FYI

LogId: c.LogID,
Leaves: leaves,
})
for _, leaf := range resp.GetResults() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the client doesn't get to find out which leaves already exist. Maybe that doesn't matter.

@mhutchinson
Copy link
Contributor

/gcbrun

therealdrake and others added 4 commits May 26, 2022 12:46
Co-Authored-By: therealdrake <alexdrake@google.com>
Co-Authored-By: therealdrake <alexdrake@google.com>
@mhutchinson
Copy link
Contributor

/gcbrun

@mhutchinson mhutchinson merged commit 5a7ccac into google:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants