Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 64 bits for node IDs and SubtreeCache #2394

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Mar 11, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2394 (bbba3dc) into master (bfb7a0d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   65.71%   65.73%   +0.02%     
==========================================
  Files         107      107              
  Lines        7758     7758              
==========================================
+ Hits         5098     5100       +2     
+ Misses       2126     2124       -2     
  Partials      534      534              
Impacted Files Coverage Δ
storage/cache/subtree_cache.go 54.16% <ø> (ø)
storage/memory/log_storage.go 3.50% <ø> (ø)
storage/mysql/log_storage.go 65.48% <ø> (ø)
log/operation_manager.go 88.35% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb7a0d...bbba3dc. Read the comment docs.

Copy link
Contributor

@pphaneuf pphaneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, thanks!

@pav-kv pav-kv marked this pull request as ready for review March 11, 2021 14:25
@pav-kv pav-kv requested a review from a team as a code owner March 11, 2021 14:25
@pav-kv pav-kv requested review from benlaurie and removed request for benlaurie March 11, 2021 14:25
@pav-kv pav-kv merged commit a431457 into google:master Mar 11, 2021
@pav-kv pav-kv deleted the nodeid_64bit branch March 11, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants