-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubtreeCache: Batch tile reads when writing nodes #2589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review commit-by-commit might make sense. |
17adc67
to
2e73d7f
Compare
PTAL |
1 similar comment
PTAL |
AlCutter
approved these changes
Jul 26, 2021
Thanks Al. @Martin2112 It would be nice to have a second pair of eyes on it too. |
Martin2112
reviewed
Jul 27, 2021
95dd136
to
326dda9
Compare
pav-kv
commented
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed Martin's comments.
Martin2112
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubtreeCache
uses two types of "read" callbacks:GetSubtreeFunc
forsingle-tile reads, and
GetSubtreesFunc
for batched reads. Besides beingcomplex, this also has performance issues: the single-node
SetNodeHash
method fetches only one tile using
GetSubtreeFunc
, so a typicalSetMerkleNodes
call results in a series of individual reads.The only use-case for node writes in Trillian (the
sequencer
) does exactly oneSetMerkleNodes
call per transaction with the entire write set, so there is noneed to sub-divide it into single-node writes in
SubtreeCache
.This change replaces the
SetNodeHash
function with a batchedSetNodes
sothat the corresponding reads are batched too, and the single-tile callback is no
longer needed and removed.
#2378
Checklist