Copied in tls lib from ct-go and removed project dependency #2744
Conversation
This fixes google#2733 More changes than I'd like to go.{mod,sum} as a result of `go mod tidy`.
mhutchinson
force-pushed
the
ct-go-going-going-gone
branch
from
c4b046c
to
300016d
Compare
|
This code had tests, should they be added too? |
IMO it's wasted cycles running tests for code that must remain a direct copy of the tested code. There is no case where this code should not be a direct copy of the version in ct-go. I did originally copy them across and backed out of it when I found the test referenced a greater surface area in the original repo. This meant either copying more stuff across to make the tests build, or else modifying the test file to remove cases that referenced this extra surface. Either route seemed like it was making the problem worse. |
There was a problem hiding this comment.
Tests are part of this code. Plus, having tests is a safety measure, in case the intent to have this code in sync is not fulfilled. I would argue that passing tests is one of the most worthwhile things to spend cycles on :D Far more cycles are spent on wrapping things in Docker and shipping them to some Cloud places.
Of the options that you mentioned, I would perhaps go with the refactoring approach. For example, those tests that require a larger surface could be factored out so that they wouldn't need to be copied.
An example of tests splitting: range_test.go and range_internal_test.go. This was done for a different reason though: avoiding circular dependencies.
| github.com/google/trillian v1.3.14-0.20210409160123-c5ea3abd4a41/go.mod h1:1dPv0CUjNQVFEDuAUFhZql16pw/VlPgaX8qj+g5pVzQ= | ||
| github.com/google/trillian v1.3.14-0.20210511103300-67b5f349eefa/go.mod h1:s4jO3Ai4NSvxucdvqUHON0bCqJyoya32eNw6XJwsmNc= |
This fixes #2733
More changes than I'd like to go.{mod,sum} as a result of
go mod tidy.