-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the version of cockroach for tests to a specific version #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./storage/crdb tests have started failing in GCP recently. Investigation shows that this is pulling the latest tagged version, which breaks hermetic builds. This PR is a test to see if using the previous version fixes the issue, and if so, I propose merging this to unblock things and then discussing with the community to look for better solutions.
@JAORMX FYI |
roger2hk
approved these changes
Apr 18, 2023
Failing snippet for those that want the gory details:
@pavelkalinnikov in case this is interesting to you. No expectation or pressure :-) |
This was referenced Apr 18, 2023
@mhutchinson There are a couple of CRDB issues with similar errors:
See if your symptoms match, or transaction does anything similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./storage/crdb tests have started failing in GCP recently. Investigation shows that this is pulling the latest tagged version, which breaks hermetic builds. This PR is a test to see if using the previous version fixes the issue, and if so, I propose merging this to unblock things and then discussing with the community to look for better solutions.