Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the trillian_log_server and trillian_log_signer binary without depending on glibc #3058

Closed
wants to merge 1 commit into from

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Aug 8, 2023

This PR avoids similar issue like google/certificate-transparency-go#1118.

Here is the distroless Dockerfile example for Go.
https://github.com/GoogleContainerTools/distroless/blob/main/examples/go/Dockerfile

Checklist

@roger2hk roger2hk marked this pull request as ready for review August 8, 2023 20:04
@roger2hk roger2hk requested a review from a team as a code owner August 8, 2023 20:04
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried these images to confirm they work without cgo? I know that there are some libraries (e.g. sqlite, which is not relevant here) that require cgo. I'm not sure if others do?

@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 9, 2023

Have you tried these images to confirm they work without cgo? I know that there are some libraries (e.g. sqlite, which is not relevant here) that require cgo. I'm not sure if others do?

Thanks for the reminder. I've revisited this issue and found out GoogleContainerTools/distroless#1342, which is an open issue related to the Debian version compatibility.

@roger2hk roger2hk closed this Aug 9, 2023
@roger2hk roger2hk deleted the cgo-enabled branch August 9, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants