AI PRP: Request Flyte Exposed UI & API #425

[hayageek]

Hi @tooryx ,
This is the PR for detecting RCE in exposed Flyte Console. Related issue is: #425
Also, created a PR in security-testbeds to setup the Flyte Console google/security-testbeds#84

Flyte supports only gRPC APIs, and I have utilized the flyte-java SDK to make these API calls. Here's how the RCE vulnerability can be exploited in an exposed Flyte Console:

1. Create a new Project using the registerProject API.
2. Within the Project, define a Task by specifying a Docker image using the createTask API.
3. Execute the Task within the cluster using the createExecution API. Note that the createExecution call may fail initially because createTask configures certain aspects in the Kubernetes cluster. In such cases, multiple attempts may be necessary. Once successfully executed, the Task spins up a Docker image and performs RCE within the POD.

[hayageek]

Hi @tooryx , Can you review the code provide comments ?

[tooryx]

Hi @hayageek,

Please be patient, a reviewer will pick-up your PR when they get through the queue.

~tooryx

[leonardo-doyensec]

Hello @hayageek, thank you for your contribution.
You can find some style issues to address down below.

[hayageek]

@leonardo-doyensec ,
I have implemented the review comments. I tested the changes, please find the attached log file & screenshot.
Below is the command to run the scanner
java -cp "main/build/libs/tsunami-main-0.0.25-SNAPSHOT-cli.jar:plugins/*" -Dflogger.level=DEBUG com.google.tsunami.main.cli.TsunamiCli --uri-target=http://127.0.0.1:30081 --scan-results-local-output-filename=out.json --scan-results-local-output-format=JSON --callback-address=172.17.0.1 --callback-port=8881 --callback-polling-uri=http://127.0.0.1:8880

flyte-log.txt

[hayageek]

@leonardo-doyensec @tooryx
Can you review the PR

[hayageek]

Hi @leonardo-doyensec,
any update ?

[hayageek]

Hi @tooryx @leonardo-doyensec
This PR was created three months ago, and I would greatly appreciate your review when you have the time. Alternatively, it might be better to hold off on accepting pull requests until you’re available to address them.

[tooryx]

Hi @hayageek,

Sorry, I know that this is frustrating. We are merging things in reverse chronological order and doing our best, but we sometimes have competing priorities as you can imagine.

That being said, I am not sure how pausing accepting pull requests would help? I actually think it would make things even worse.

~tooryx

[leonardo-doyensec]

Hello @hayageek,
i'm noticing that the callback server receives only the polling request along with this error
INFO: Interaction with secret '<redacted>' NOT found and polled by IP <redacted>
Can you please check?

[hayageek]

@leonardo-doyensec ,
It seems the request successfully reached the callback server, indicating that RCE was executed in the container. You can refer to the relevant code here: InteractionPollingHandler.java#L62.

Could you share the commands you're using to run both the callback server and the Tsunami scanner? It appears there might be an issue with the callback server's IP address.