Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI PRP: AutoGPT RCE detector #546

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

AI PRP: AutoGPT RCE detector #546

wants to merge 6 commits into from

Conversation

am0o0
Copy link
Contributor

@am0o0 am0o0 commented Nov 2, 2024

Hi @tooryx, Sorry for the delay, and thanks for your patience! :)
#536
google/security-testbeds#96

@am0o0
Copy link
Contributor Author

am0o0 commented Nov 29, 2024

@tooryx may I ask you to set this PR as my primary AI PRP PR?

@giacomo-doyensec
Copy link
Collaborator

giacomo-doyensec commented Dec 4, 2024

Hello @am0o0, thanks for your contribution!

I’ve verified that the plugin generally works but I’d like to point out some improvements / edge cases ;

  1. The plugin lacks a fingerprint detection phase, please check whether the service is an AutoGPT instance before sending the payload, this is to avoid sending the payload to all the web services that the scanner encounter.
  2. The detection works only if the AutoGPT service is in a “clean state” (it’s not processing other requests), can you develop a workaround for this?
  3. In the detect phase check if responses are consistent before sending the next one, if they aren’t return an error. I had multiple time-out or fails in detection due to the plugin assuming that the second and third request returned 200. This is related to (2).
  4. Ensure to run the google-java-format tool (statements should be <=100 chars and the test code imports some unused libraries)
  5. I think that the return false at ExposedAutoGptApiDetector.java#166 inside the catch statement is redundant as the next line would be executed anyway

@am0o0
Copy link
Contributor Author

am0o0 commented Dec 4, 2024

@giacomo-doyensec Hi
Thank you for reviewing my PR.
I tried to fix all the issues you mentioned, about issues 2 and 3 please review again if what I've added is enough for a clean state check.

Copy link
Collaborator

@giacomo-doyensec giacomo-doyensec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick reply!

It looks like the detector is working correctly now, I just added some changes to conform to Google's Java format.

@giacomo-doyensec
Copy link
Collaborator

LGTM - Approved
@maoning we can merge this and google/security-testbeds#96

Reviewer: Giacomo, Doyensec
Plugin: CVE-2024-6091 - AutoGPT RCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants