Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeflow weak credential tester #552

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grandsilva
Copy link
Contributor

@grandsilva grandsilva commented Nov 22, 2024

@tooryx I could not find out why the kubeflow weak credential module which I've added in this PR doesn't work, the new default credentials which are for kubeflow are not passed to this module at all!

testbeds:
google/security-testbeds#99


private boolean isKubeflowAccessible(NetworkService networkService, TestCredential credential) {
final String rootUri = buildWebApplicationRootUrl(networkService);
// logger.atWarning().log("======================= '%s'", credential.username());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooryx I tried to find out which user/pass is passed to here and only the TOP_100_PASSWORDS passed to this method for testing the login. but I need to use the default credentials only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grandsilva,

I would need to look more closely, but if I remember correctly, the weak credential tester will use the service name that is reported by nmap. The default credentials are defined for service "kubeflow" but I am not sure if nmap actually reports kubeflow with this name. Could you try to tweak the service name in the default credentials file and let me know if this is causing the issue?


private boolean isKubeflowAccessible(NetworkService networkService, TestCredential credential) {
// logger.atWarning().log("======================= '%s'", credential.username());
final String rootUri = buildWebApplicationRootUrl(networkService);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java -cp "tsunami-main-0.0.24-SNAPSHOT-cli.jar:/home/user/tsunami/Plugins/*"   -Dtsunami.config.location=/home/user/tsunami/tsunami_tcs.yaml   com.google.tsunami.main.cli.TsunamiCli   --uri-target=http://127.0.0.1:8080  --scan-results-local-output-format=JSON   --scan-results-local-output-filename=/tmp/tsunami-output.json  --http-client-trust-all-certificates

@tooryx I tried the above command, but I received WARNING: Plugin '/Tsunami Team (tsunami-dev@google.com)/VULN_DETECTION/GenericCredentialDetectorPlugin/0.1' failed: null which because of some internal error in buildWebApplicationRootUrl the plugin doesn't work too, this issue is new this time for me. I tried to manually create the rootUri and this solved the issue. but still even with the fingerprint phase and adding the "kubeflow" service name I can't receive the default credentials.

Also, could you please tag this PR to the main PR, please?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grandsilva,

I haven't seen any testbed, you should also create one here https://github.com/google/security-testbeds to fully test your plugin. If you create it I can check the plugin and what is going wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RaulDoyensec
I uploaded an early version just now
google/security-testbeds#99

thank you for helping me on this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RaulDoyensec
I updated the testbed to a fully automatic bash script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants