AI PRP: localai CVE-2024-2029 RCE #558
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
devampkid
changed the title
There was a problem hiding this comment.
Hello @devampkid, thanks for your contribution!
Below, you’ll find a few issues to address, along with some suggestions. Please ensure that you run the google-java-format tool on all files before submitting the updated version.
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
...2029/src/main/resources/com/google/tsunami/plugins/detectors/rce/cve20242029/simpleAudio.ogg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hello @devampkid, thanks for the updates!
I left a couple of comments about improvements that can be applied down below.
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hello @devampkid,
here you can find some minor style issues to address, then the plugin should be ok.
Thank you!
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
.../com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetectorTest.java
Outdated
Show resolved
Hide resolved
.../com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetectorTest.java
Outdated
Show resolved
Hide resolved
.../com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetectorTest.java
Outdated
Show resolved
Hide resolved
|
hi @giacomo-doyensec sorry I forgot to apply the google java format before the last commit. |
...java/com/google/tsunami/plugins/detectors/rce/cve20242029/LocalAiCve20242029RceDetector.java
Outdated
Show resolved
Hide resolved
Hii
I wrote this plugin after my request got approved here: #554
the testbed: google/security-testbeds#100