Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #106 as discussed #118

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ikkisoft
Copy link
Contributor

As discussed in #106, this PR introduces the following changes:

  • Removed setTrustAllCertificates from the client since this was not meant to be customizable
  • Set setTrustAllCertificates to true by default
  • Ability for users to turn it off via the --http-client-trust-all-certificates flag. In order not to change its name, I just made the argument with arity 1 so that it's possible to set the flag to true or false.

Important: given we're deprecating the setTrustAllCertificates method, there are three old plugins that require updates. I will make a corresponding PR on https://github.com/google/tsunami-security-scanner-plugins

@copybara-service copybara-service bot merged commit 267bafd into google:master Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants