Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniSim defaults to Onnx runtime on GPU #14

Merged
merged 7 commits into from
May 16, 2024
Merged

UniSim defaults to Onnx runtime on GPU #14

merged 7 commits into from
May 16, 2024

Conversation

MarinaZhang
Copy link
Collaborator

@MarinaZhang MarinaZhang commented May 16, 2024 •
edited
Loading

This PR introduces two small changes:

  • Defaults to Onnx for both CPU and GPU if TensorFlow is not installed
  • Install onnxruntime-gpu by default instead of onnxruntime
  • Require TensorFlow <2.16 because there are issues running UniSim with Keras 3 (tracking issue Issues with UniSim when using Keras 3/ TF 2.16.1 #15)

@MarinaZhang MarinaZhang added bug Something isn't working documentation Improvements or additions to documentation labels May 16, 2024
@MarinaZhang MarinaZhang added this to the Alpha Release milestone May 16, 2024
@MarinaZhang MarinaZhang requested a review from owenvallis May 16, 2024 17:46
@MarinaZhang MarinaZhang self-assigned this May 16, 2024
@MarinaZhang MarinaZhang requested a review from ebursztein May 16, 2024 18:10
@MarinaZhang MarinaZhang merged commit 0e2e3a0 into main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvallis owenvallis Awaiting requested review from owenvallis

@ebursztein ebursztein Awaiting requested review from ebursztein

Assignees

@MarinaZhang MarinaZhang

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
Alpha Release
Development

Successfully merging this pull request may close these issues.
1 participant
@MarinaZhang