Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Max UUID #144

Closed
wants to merge 4 commits into from
Closed

add Max UUID #144

wants to merge 4 commits into from

Conversation

it512
Copy link
Contributor

@it512 it512 commented Dec 8, 2023

@it512 it512 requested a review from a team as a code owner December 8, 2023 17:39
@it512 it512 closed this Dec 8, 2023
bormanp
bormanp reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@bormanp bormanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable addition.

bormanp
bormanp reviewed Dec 11, 2023
View reviewed changes
hash.go
@@ -17,6 +17,12 @@ var (
NameSpaceOID = Must(Parse("6ba7b812-9dad-11d1-80b4-00c04fd430c8"))
NameSpaceX500 = Must(Parse("6ba7b814-9dad-11d1-80b4-00c04fd430c8"))
Nil UUID // empty UUID, all zeros

// The Max UUID is special form of UUID that is specified to have all 128 bits set to 1.
MAX = UUID{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Max or MaxUUID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bormanp bormanp bormanp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@it512 @bormanp