Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff as formatter for Python #238

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Add ruff as formatter for Python #238

merged 1 commit into from
Aug 25, 2024

Conversation

dbarnett
Copy link
Contributor

Fixes #223.

Copy link

google-cla bot commented Aug 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dbarnett
Copy link
Contributor Author

@snu5mumr1k can you also approve the test workflows to run? https://github.com/google/vim-codefmt/actions/runs/10544889502

And then I think you'll need to merge it for me since I don't have write access to the repo anymore.

@snu5mumr1k snu5mumr1k merged commit 123b4de into google:master Aug 25, 2024
4 checks passed
@dbarnett dbarnett deleted the ruff branch August 25, 2024 18:50
@dbarnett
Copy link
Contributor Author

Hmm, FYI might be something brittle with how args are getting passed... after using this a while at one point I tried to format part of a file and it formatted every file in the repo in-place instead.

@dbarnett
Copy link
Contributor Author

Figured it out, fixing that in #239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ruff as formatter for Python
2 participants