Redefine highlights on colorscheme changes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that they get updated to match the new color definitions.
blueyed
force-pushed
the
redefine-hl
branch
from
4429ebb to
b5ab841
Compare
dbarnett
reviewed
Oct 9, 2017
| @@ -27,6 +27,7 @@ endif | |||
| if !exists('s:coverage_states') | |||
| let s:coverage_states = ['covered', 'uncovered', 'partial'] | |||
| endif | |||
| let s:highlights_defined = 0 | |||
There was a problem hiding this comment.
Don't you need to guard this with if exists('s:highlights_defined')? autoload files can be re-executed whenever and AFAICT this shouldn't be reset to 0 in that case.
|
|
||
| "" | ||
| " Re-define highlights after the colorscheme was changed. | ||
| augroup coverage_highlights |
There was a problem hiding this comment.
Autocmds should be defined in a file plugin/autocmds.vim (w/ the standard maktaba#plugin#Enter guard) so they're loaded in a predictable manner and can be disabled if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that they get updated to match the new color
definitions.