Only unplace own signs #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
reviewed
Oct 7, 2017
| let name = split(cols[-1], '=')[-1] | ||
| if name[0:8] ==# 'coverage_' | ||
| let id = split(cols[-2], '=')[-1] | ||
| let id = s:sign_id |
There was a problem hiding this comment.
Why is id here immediately overwritten?
There was a problem hiding this comment.
Good catch.. will have to look into it.
| for s in signs | ||
| let cols = split(s) | ||
| let name = split(cols[-1], '=')[-1] | ||
| if name[0:8] ==# 'coverage_' |
There was a problem hiding this comment.
Could you use maktaba#string#StartsWith(l:name, 'coverage_') vs. hard-coded indexes?
There was a problem hiding this comment.
Hmm, I think this it is not necessare to use a helper method in this case, but was not aware of it.
| if has_key(s:visible, expand('%:p')) | ||
| execute 'sign unplace * file=' . expand('%:p') | ||
| " Unplace our signs for the current file. | ||
| let fname = bufname('%') |
There was a problem hiding this comment.
Helpers for programmatically listing and unplacing signs would be great to have in maktaba (see google/vim-maktaba#142). Consider splitting them out as standalone helper functions so they're easier to migrate over.
blueyed
referenced
this pull request
in alfredodeza/coveragepy.vim
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.