[WIP] Python provider: report partial lines and percentage from coveragepy #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Apr 21, 2018
| if has_key(l:data, 'percentage') | ||
| let l:stats.percentage = l:data.percentage | ||
| else | ||
| let l:stats.percentage = printf('%.2f%%', 100.0 * l:stats.covered / l:stats.total) |
There was a problem hiding this comment.
This is off in case of partial lines (which needs additional information about the number of branches). That's why I've made it to use the information from Coverage.py, but it is relevant in general.
|
There's a mismatch in the line counts in the test ("3/7" instead of "3/6"). Is that expected? |
|
No, needs more work. |
blueyed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would make sense to squash-merge probably.
Uses a private interface with coveragepy (see nedbat/coveragepy#44).