Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing comma (fix #102) #106

Closed
wants to merge 1 commit into from
Closed

Fix a missing comma (fix #102) #106

wants to merge 1 commit into from

Conversation

itchyny
Copy link

@itchyny itchyny commented Nov 22, 2014

Fixes #102.

@dbarnett
Copy link
Contributor

Thanks! Did you see the CLA details at https://github.com/google/vim-maktaba/blob/master/CONTRIBUTING.md? I couldn't find you in the signers list.

@itchyny
Copy link
Author

itchyny commented Nov 22, 2014

Sorry, no. Hmm, that seems to be a complicated process... The fix is just appending a comma (diff in a single character!) so please close this pull request and fix directly at your (master) branch. Who found this bug? That's vimlint, not me.

@googlebot
Copy link
Collaborator

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@dbarnett
Copy link
Contributor

Fair enough. Sucks that the CLA overhead discourages people from contributing. =(

@dbarnett dbarnett closed this Nov 22, 2014
@itchyny itchyny deleted the fix-missing-comma branch November 22, 2014 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in setting.vim
3 participants