Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Volley builds with errorprone. #162

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Integrate Volley builds with errorprone. #162

merged 2 commits into from
Apr 9, 2018

Conversation

jpd236
Copy link
Collaborator

@jpd236 jpd236 commented Apr 6, 2018

All error prone warnings+errors now lead to compile failures.
Existing failures have been fixed or suppressed, including:

  • Uses of LinkedList when ArrayList is likely to be better
  • Inner classes that weren't static but could be
  • Potentially shorter-than-intended waits in RequestFuture#get due to spurious wakeups

Fixes #100

@jpd236
Integrate Volley builds with errorprone.
dc16c74 
All error prone warnings+errors now lead to compile failures.
Existing failures have been fixed or suppressed.

Fixes google#100
@jpd236 jpd236 requested a review from jjoslin April 6, 2018 01:14
@jpd236
Fix error prone issues in tests, and revert behavior change.
d1fd87f 
split([string], -1) breaks the unit tests, so to be safe revert back
to split([string], 0), just with the argument being made explicit.
@jpd236 jpd236 merged commit 5307293 into google:master Apr 9, 2018
@jpd236 jpd236 deleted the error-prone branch April 9, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoslin jjoslin jjoslin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check all code against error-prone; enforce correctness for future commits
2 participants
@jpd236 @jjoslin