Remove residual logs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a log that was left from a previous change and which adds to much spam to the output. This is important especially for the --report evaluation mode, where the tool should only print a JSON that can be consumed by other tools. Add a test that checks if the --report evaluation mode prints something that can be parsed as JSON to make sure no future residual logs break this behaviour.
garanj
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a log that was left from a previous change and which adds to much spam to the output. This is important especially for the
--reportevaluation mode, where the tool should only print a JSON that can be consumed by other tools. Add a test that checks if the--reportevaluation mode prints something that can be parsed as JSON to make sure no future residual logs break this behaviour.