Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git hash to the jar's manifest file #9

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add git hash to the jar's manifest file #9

merged 2 commits into from
Jan 16, 2024

Conversation

robcos
Copy link
Collaborator

@robcos robcos commented Jan 16, 2024

By inspecting META-INF/MANIFEST.MF we'll be able to see which version of the jar is being used. Subsequently, we'll add a command line option to actually print it out.

@robcos robcos changed the title Update gradle-publish.yml to show the git hash Add git hash to the jar's manifest file Jan 16, 2024
@robcos
Copy link
Collaborator Author

robcos commented Jan 16, 2024

#8

@robcos robcos requested review from lucianbc and garanj January 16, 2024 13:51
Copy link
Member

@lucianbc lucianbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print some kind of human readable version in the output on each run? Testers usually paste the output in bugs when having issues.

@robcos
Copy link
Collaborator Author

robcos commented Jan 16, 2024

Yes, separate change though.

@robcos robcos force-pushed the robcos-patch-2 branch 2 times, most recently from f3db517 to 17262b3 Compare January 16, 2024 14:45
@robcos robcos merged commit c0a06a8 into main Jan 16, 2024
2 checks passed
@robcos robcos deleted the robcos-patch-2 branch January 16, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants