Skip to content

Commit

Permalink
address diagnostics and update to a more recent package:lints
Browse files Browse the repository at this point in the history
  • Loading branch information
devoncarew committed Oct 2, 2024
1 parent b181c9e commit 98d5284
Show file tree
Hide file tree
Showing 16 changed files with 32 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
sdk: [3.0.0, stable, dev]
sdk: [3.1, stable, dev]
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
Expand All @@ -66,7 +66,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
sdk: [3.0.0, stable, dev]
sdk: [3.1, stable, dev]
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
Expand Down
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 3.0.4-wip
## 3.0.4

* Require Dart 3.0.
* Require Dart 3.1.
* Update to the latest package:lints.

## 3.0.3

Expand Down
2 changes: 0 additions & 2 deletions lib/src/common/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,5 @@ WebDriverHandler getHandler(WebDriverSpec spec) {
return W3cWebDriverHandler();
case WebDriverSpec.Auto:
return InferWebDriverHandler();
default:
throw UnsupportedError('Unexpected web driver spec: $spec.');
}
}
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: webdriver
version: 3.0.4-wip
version: 3.0.4
description: >-
Provides WebDriver bindings for Dart. Supports WebDriver JSON interface and
W3C spec. Requires the use of WebDriver remote server.
repository: https://github.com/google/webdriver.dart

environment:
sdk: ^3.0.0
sdk: ^3.1.0

dependencies:
matcher: ^0.12.10
Expand All @@ -16,5 +16,5 @@ dependencies:

dev_dependencies:
archive: ^3.3.0
lints: ^3.0.0
lints: ^4.0.0
test: ^1.16.0
2 changes: 2 additions & 0 deletions test/firefox_alert_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_command_event.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_cookies_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_navigation_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_target_locator_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_timeouts_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_w3c_basic_sync_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_w3c_keyboard_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_w3c_mouse_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_web_driver_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_web_element_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';
import 'package:webdriver/sync_core.dart';

Expand Down
2 changes: 2 additions & 0 deletions test/firefox_window_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// limitations under the License.

@Tags(['ff'])
library;

import 'package:test/test.dart';

import 'package:webdriver/sync_core.dart';
Expand Down

0 comments on commit 98d5284

Please sign in to comment.