address diagnostics and update to a more recent package:lints #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
Test are failing on firefox (as per #292). |
|
Assign? or you want me to review it? |
kevmoo
reviewed
Oct 2, 2024
kevmoo
approved these changes
Oct 2, 2024
Oops - I meant as a reviewer. |
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 4, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. file (https://github.com/google/file.dart/compare/855831c..6842fea): 6842fea 2024-10-03 dependabot[bot] Bump actions/checkout from 4.1.7 to 4.2.0 (dart-archive/file.dart#243) logging (https://github.com/dart-lang/logging/compare/05116e7..6fa0560): 6fa0560 2024-10-04 lawther Fix typo in README (dart-lang/logging#173) mockito (https://github.com/dart-lang/mockito/compare/b66be81..3de6754): 3de6754 2024-10-03 Googler Add "topics" to package mockito tools (https://github.com/dart-lang/tools/compare/42996fd..d4995d4): d4995d47 2024-10-02 Hannah Jin Add more parameters (androidAppId and iosBundleId) in devtools events. (dart-lang/tools#295) e5b699fd 2024-10-02 Devon Carew Update labeler.yml (dart-lang/tools#597) webdriver (https://github.com/google/webdriver.dart/compare/b181c9e..accfed5): accfed5 2024-10-02 dependabot[bot] Bump actions/checkout from 4.1.7 to 4.2.0 (google/webdriver.dart#303) aa0165f 2024-10-02 Devon Carew address diagnostics and update to a more recent package:lints (google/webdriver.dart#304) Change-Id: I1094c34f0fe646e59e7e6f91450fee2eacdee747 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388053 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a CI failure and preps to publish a new version.