Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/wire: use full go run command in go:generate comment #268

Merged

Conversation

steebchen
Copy link
Contributor

Change the go:generate command to use the full go run ... command
to ensure the version specified in the current go module is used
instead of the global binary.

fix #160

Change the go:generate command to use the full go run ... command
to ensure the version specified in the current go module is used
instead of the global binary.

fix google#160
@google-cla
Copy link

google-cla bot commented Dec 4, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Cannot accept contribution until Google CLA is signed. label Dec 4, 2020
@steebchen
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels Dec 4, 2020
@zombiezen
Copy link
Collaborator

Sorry for the delay. This is still on my radar to review, but I've been swamped with other life commitments. I will try to get to this sometime over the next few weeks.

@steebchen
Copy link
Contributor Author

steebchen commented Dec 18, 2020

Sure, no worries

Copy link
Collaborator

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: use go run in generate line
2 participants