Recursive invocations for node --run in Windows are incorrect #1168
Comments
Merged
aomarks
added a commit
that referenced
this issue
Aug 22, 2024
Adds support for the new node --run feature which is available starting in Node 22 (basically npm run but faster, see https://nodejs.org/en/blog/announcements/v22-release-announce#running-packagejson-scripts and https://www.yagiz.co/developing-fast-builtin-task-runner/). Note that node --run is stricter than the other runners when it comes to distinguishing between arguments for the runner vs the script, so an additional -- is needed to set wireit flags and script flags (explained in the README). Thank you very much to @anonrig for adding the environment variables this required (nodejs/node#53032, nodejs/node#53058) and @justinfagnani for filing the issue (nodejs/node#52673)! There is a problem with recursive invocations on Windows that I believe is a Node bug but need to double-check, tracking at #1168. Fixes #1094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tests for
node --runnamedrun recurse -> run start --watchandrun recurse -> run start --watch --extrafail on Windows. It seems to be a similar problem to what Yarn does, where when you do recursive calls, the environment variable that says what script we're in (NODE_RUN_SCRIPT_NAMEin this case) reflects the first call, instead of the last.This is very likely a Windows-specific Node bug, so the next step is to confirm it and file an issue. Then we can un-skip those tests in Windows once fixed.
The text was updated successfully, but these errors were encountered: