Allow wireit-only scripts #653
Conversation
| // This form is useful when using package managers like yarn or pnpm which | ||
| // do not automatically add all parent directory `node_modules/.bin` | ||
| // folders to PATH. | ||
| /^(\.\.\/)+node_modules\/\.bin\/wireit$/.test(command) || |
There was a problem hiding this comment.
Do you ever need to handle ./node_moduules/...? Like in a non-monorepo with Yarn>
There was a problem hiding this comment.
I think if it's installed to ./node_modules/.bin then every package manager should work with just wireit, no need to write ./node_modules/.... npm also automatically checks all parent directory node_modules/.bin, but yarn and pnpm don't do that. So this just handles that gap.
| // creating a new object, because other configs may be referencing this | ||
| // exact object in their dependencies. | ||
| const remainingConfig: LocallyValidScriptConfig = { | ||
| ...placeholder, |
There was a problem hiding this comment.
Why do you need this spread if you just assign back into placeholder?
There was a problem hiding this comment.
So that the :LocallyVaildScriptConfig type annotation can be there, so that we know we're ending up with an object that fully satisfies that interface.
src/analyzer.ts
Outdated
| reason: 'script-not-wireit', | ||
| script: placeholder, | ||
| diagnostic: { | ||
| message: `This command should just be "wireit", as this script is configured in the wireit section.`, |
There was a problem hiding this comment.
nit: break up long string?
Allows defining a script in the `wireit` section even if it doesn't have an entry in `scripts`. Such scripts can be used as dependencies of other wireit scripts, but can't be run directly. This is nice for intermediate scripts that are created only for internal organization, and would not really make sense to invoke directly. Fixes google#644
Allows defining a script in the
wireitsection even if it doesn't have an entry inscripts. Such scripts can be used as dependencies of other wireit scripts, but can't be run directly.This is nice for intermediate scripts that are created only for internal organization, and would not really make sense to invoke directly.
Fixes #644