Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: unified include/exclude file #224

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Conversation

octo
Copy link
Contributor

@octo octo commented Nov 26, 2024

Implementation of #223. Review comments are very welcome, but let's keep the design discussion in #223.

Fixes: #223

Copy link
Collaborator

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, a couple small comments

path_collector.go Outdated Show resolved Hide resolved
path_collector.go Outdated Show resolved Hide resolved
path_collector_test.go Show resolved Hide resolved
@octo
Copy link
Contributor Author

octo commented Nov 26, 2024

I also added a commit updating the docs to reflect these changes.

@octo octo force-pushed the pattern-file branch 4 times, most recently from 8fb93d3 to fe4ea1e Compare November 26, 2024 17:00
docs/config-file.md Show resolved Hide resolved
docs/paths.md Outdated Show resolved Hide resolved
octo and others added 2 commits November 27, 2024 08:36
Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>
```shell
make integrationtest_update
```
Copy link
Collaborator

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature!

@braydonk braydonk merged commit 399ca35 into google:main Nov 27, 2024
5 checks passed
@octo octo deleted the pattern-file branch November 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature discussion: unified include/exclude file
2 participants