Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add configuration for building container images #230

Merged
merged 7 commits into from
Jan 10, 2025
Merged

fix: add configuration for building container images #230

merged 7 commits into from
Jan 10, 2025

Conversation

fsrv-xyz
Copy link
Contributor

See #229 for reference

@fsrv-xyz
fix: add automation for building docker image
15a314d 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@fsrv-xyz
chore: rename container build job name
5ae9431 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
braydonk
braydonk reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Seems like it will be useful to people. Left some comments on the Dockerfile. I'm certainly not a Docker expert, but making a few suggestions from other single-Go-binary Dockerfiles I've made.

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@braydonk
Copy link
Collaborator

Forgot to add in my comment: could you also amend the documentation to provide instructions for where to pull the container from and some usage examples?

@fsrv-xyz
fix(Dockerfile): add entrypoint specification
0fb948a 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@fsrv-xyz
doc: add container image usage to README.md
78cb806 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@fsrv-xyz
doc: adjust docker run command in README; set workdir for directory m…
fc1bac3 
…apping to work

Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@fsrv-xyz
doc: more specific example for docker run usecase
dd9863e 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@fsrv-xyz
Copy link
Contributor Author

I have added some documentation and adjustments to the Dockerfile which ensures the WORKDIR (for the usecase of running the docker image locally) is explicitly specified.

braydonk
braydonk approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@braydonk braydonk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a non-blocking comment, but otherwise LGTM.

In an effort to save potential issues, since I will not be online again til Jan 2 I am going to wait until then to merge and cut the release with this. If there were an issue I wouldn't be online to solve it, and no one else would be around with permissions on this repo.

Thank you for the feature!

README.md Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@fsrv-xyz
doc: add license header to Dockerfile
3a03621 
Signed-off-by: Florian Bauer <florian@fsrv.xyz>
@braydonk
Copy link
Collaborator

braydonk commented Dec 23, 2024 •
edited
Loading

Could you also add the license header to the Dockerfile? Should be able to just run make install_tools addlicense

You did it at the same time as I made the comment; thanks!

@braydonk braydonk merged commit 81ffee4 into google:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braydonk braydonk braydonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsrv-xyz @braydonk