Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python 3.12 for CI #1132

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Use python 3.12 for CI #1132

merged 8 commits into from
Oct 10, 2023

Conversation

Spitfire1900
Copy link
Contributor

No particular need for 3.9 - 3.11 (See https://github.com/Spitfire1900/yapf/blob/3.12/yapftests/reformatter_basic_test.py#L25-L26).

Should be ready for 3.12 once it goes GA.

@Spitfire1900
Copy link
Contributor Author

Should we continue to have a different test for each OS<->Python version combination that is warranted or should each OS test all Python versions supported by YAPF?

@bwendling
Copy link
Member

I think having each OS test all Python versions would be a bit overkill. I'm fine with having one (Linux) test all of them and then the other platforms are tested with a single version (most recent?).

@hartwork
Copy link
Contributor

hartwork commented Oct 6, 2023

@Spitfire1900 Python 3.12 is available by now.
@bwendling we have checks for >=3.8 and >=3.10 in the code base and you mentioned that Python 3.7 is not dead inside of Google. Taking all that I would vote for covering 3.7, 3.8, 3.10, 3.12 but not 3.9 and not 3.11 to save resources.

@Spitfire1900
Copy link
Contributor Author

Spitfire1900 commented Oct 7, 2023

>=3.10 means that 3.9-3.11 is not applicable, and really only testing on 3.7, 3.8, and 3.12 is required.

@Spitfire1900 Spitfire1900 marked this pull request as ready for review October 7, 2023 01:04
@hartwork
Copy link
Contributor

hartwork commented Oct 7, 2023

>=3.10 means that 3.9-3.11 is not applicable, and really only testing on 3.7, 3.8, and 3.12 is required.

@Spitfire1900 I don't understand. Could you elaborate? On my part: if we check for >=3.10 but test with say 3.12 but not 3.10, technically we have no guarantee that that the code actually works with 3.10 and doesn't e.g. require >=3.11 in reality.

@Spitfire1900
Copy link
Contributor Author

Spitfire1900 commented Oct 7, 2023

Fair. Technically we're just verifying the condition>3.10 but not ==3.10.

@bwendling bwendling merged commit 96e3d4a into google:main Oct 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants