-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python 3.12 for CI #1132
Use python 3.12 for CI #1132
Conversation
Should we continue to have a different test for each OS<->Python version combination that is warranted or should each OS test all Python versions supported by YAPF? |
I think having each OS test all Python versions would be a bit overkill. I'm fine with having one (Linux) test all of them and then the other platforms are tested with a single version (most recent?). |
@Spitfire1900 Python 3.12 is available by now. |
|
@Spitfire1900 I don't understand. Could you elaborate? On my part: if we check for >=3.10 but test with say 3.12 but not 3.10, technically we have no guarantee that that the code actually works with 3.10 and doesn't e.g. require >=3.11 in reality. |
Fair. Technically we're just verifying the condition |
No particular need for 3.9 - 3.11 (See https://github.com/Spitfire1900/yapf/blob/3.12/yapftests/reformatter_basic_test.py#L25-L26).
Should be ready for 3.12 once it goes GA.