Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPLIT_ARGUMENTS_WHEN_COMMA_TERMINATED for one-item argument lists #1142

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix SPLIT_ARGUMENTS_WHEN_COMMA_TERMINATED for one-item argument lists #1142

merged 3 commits into from
Sep 19, 2023

Conversation

alexey-pelykh
Copy link
Contributor

Turn

r = f0(1,)

into

r = f0(
    1,
)

in case SPLIT_ARGUMENTS_WHEN_COMMA_TERMINATED is enabled

@alexey-pelykh alexey-pelykh force-pushed the fix/split_arguments_when_comma_terminated-single-argument branch from a9b878e to dd9aa61 Compare September 14, 2023 07:52
@alexey-pelykh alexey-pelykh mentioned this pull request Sep 14, 2023
Closed
bwendling
bwendling reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@bwendling bwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a blurb in CHANGLOG?

@alexey-pelykh alexey-pelykh force-pushed the fix/split_arguments_when_comma_terminated-single-argument branch from dd9aa61 to 4d49ea0 Compare September 19, 2023 03:36
@alexey-pelykh
Copy link
Contributor Author

@bwendling done

@bwendling
Update CHANGELOG.md
dc52dac 
Add "Fixed" tag.
bwendling
bwendling approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bwendling bwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bwendling bwendling merged commit 11b284e into google:main Sep 19, 2023
11 checks passed
@alexey-pelykh alexey-pelykh deleted the fix/split_arguments_when_comma_terminated-single-argument branch September 20, 2023 04:27
@alexey-pelykh alexey-pelykh mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spitfire1900 Spitfire1900 Spitfire1900 approved these changes

@bwendling bwendling bwendling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-pelykh @bwendling @Spitfire1900