Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend CONTINUATION_ALIGN_STYLE for space indentation #791

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

yinyin
Copy link
Contributor

@yinyin yinyin commented Jan 4, 2020

This PR make CONTINUATION_ALIGN_STYLE=FIXED and CONTINUATION_ALIGN_STYLE=VALIGN-RIGHT option available for indenting with space.

Ref: #769

Compare to previous PR (#774) this one should solve the extra line break issue.


Changes made:

  • let new line indent generation method in format decision be continuation
    align style aware
  • simplify tab replacement in format token as styling logic moved to format decision mostly

@coveralls
Copy link

coveralls commented Jan 4, 2020

Coverage Status

Coverage decreased (-0.08%) to 96.197% when pulling 4c09d51 on yinyin:cont-align-style-w-space-3 into e3b159b on google:master.

* let new line indent generation method in format decision be continuation
  align style aware
* simplify tab replacement in format token
* update documentation
@yinyin yinyin force-pushed the cont-align-style-w-space-3 branch from 4249738 to 4c09d51 Compare January 23, 2020 17:36
@bwendling bwendling merged commit f967fd6 into google:master Apr 23, 2020
brianmego pushed a commit to brianmego/yapf that referenced this pull request Aug 4, 2020
* let new line indent generation method in format decision be continuation
  align style aware
* simplify tab replacement in format token
* update documentation

Co-authored-by: Bill Wendling <5993918+gwelymernans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants