Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml support #893

Merged
merged 10 commits into from
Mar 12, 2021
Merged

pyproject.toml support #893

merged 10 commits into from
Mar 12, 2021

Conversation

hirosassa
Copy link
Contributor

@hirosassa hirosassa commented Jan 27, 2021 •
edited
Loading

This PR is for #708

I added pyproject.toml support.
Section syntax of pyproject.toml file is the same as @samypr100 's explanation in #708.

Please let me know if I miss anything.
Thank you.

@google-cla google-cla bot added the cla: yes label Jan 27, 2021
hirosassa
hirosassa commented Jan 27, 2021
View reviewed changes
yapf/yapflib/style.py Outdated
@@ -17,6 +17,8 @@
import re
import textwrap

import toml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[help wanted] I added external dependency because there's no toml loader in standard libraries. Is this OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this to be seamless. So if someone doesn't have the toml package installed, then we just skip this support all together. Is it possible to import the toml conditionally and if it fails to import set a flag or something?

Copy link
Contributor Author

@hirosassa hirosassa Feb 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you! Fixed this in 58b9034 and 04b1111

@coveralls
Copy link

coveralls commented Feb 7, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 93.728% when pulling 04b1111 on hirosassa:add-pyproject-integration into a53e340 on google:main.

@hirosassa
Copy link
Contributor Author

@gwelymernans Hi! This PR is ready for review.
If miss anything, please let me know.
Thank you!

bwendling
bwendling reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@bwendling bwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

yapf/yapflib/style.py Outdated
@@ -17,6 +17,8 @@
import re
import textwrap

import toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this to be seamless. So if someone doesn't have the toml package installed, then we just skip this support all together. Is it possible to import the toml conditionally and if it fails to import set a flag or something?

@bwendling bwendling merged commit 664e7c0 into google:main Mar 12, 2021
This was referenced Mar 15, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@hirosassa hirosassa deleted the add-pyproject-integration branch March 15, 2021 13:41
This was referenced Mar 16, 2021
Closed
Merged
@KuSi833 KuSi833 mentioned this pull request Jul 9, 2021
Closed
@SauravMaheshkar SauravMaheshkar mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwendling bwendling bwendling left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirosassa @coveralls @bwendling