Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extend_vec_zeroed and insert_vec_zeroed fallible #1653

Closed
Tracked by #671
joshlf opened this issue Sep 15, 2024 · 0 comments · Fixed by #1658
Closed
Tracked by #671

Make extend_vec_zeroed and insert_vec_zeroed fallible #1653

joshlf opened this issue Sep 15, 2024 · 0 comments · Fixed by #1658
Labels
blocking-next-release This issue should be resolved before we release on crates.io

Comments

@joshlf
Copy link
Member

joshlf commented Sep 15, 2024

Follow up on #1478 to make extend_vec_zeroed and insert_vec_zeroed return errors on allocation failure.
@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label Sep 15, 2024
@joshlf joshlf mentioned this issue Sep 15, 2024
Open
87 tasks
joshlf added a commit that referenced this issue Sep 15, 2024
@joshlf
Make extend_vec_zeroed, insert_vec_zeroed fallible
9ba613a 
They now return `AllocError` on allocation failure. `insert_vec_zeroed`
still panics if its `position` argument is out-of-bounds.

Closes #1653
@joshlf joshlf mentioned this issue Sep 15, 2024
Merged
joshlf added a commit that referenced this issue Sep 15, 2024
@joshlf
Make extend_vec_zeroed, insert_vec_zeroed fallible
1eb1ca6 
They now return `AllocError` on allocation failure. `insert_vec_zeroed`
still panics if its `position` argument is out-of-bounds.

This requires using `Vec::try_reserve`, which is unstable before 1.57.0.
Since our MSRV is currently 1.56.0, these functions are now
conditionally compiled and only available on 1.57.0 and later.

Closes #1653
joshlf added a commit that referenced this issue Sep 15, 2024
@joshlf
Make extend_vec_zeroed, insert_vec_zeroed fallible
72289ae 
They now return `AllocError` on allocation failure. `insert_vec_zeroed`
still panics if its `position` argument is out-of-bounds.

This requires using `Vec::try_reserve`, which is unstable before 1.57.0.
Since our MSRV is currently 1.56.0, these functions are now
conditionally compiled and only available on 1.57.0 and later.

Closes #1653
joshlf added a commit that referenced this issue Sep 15, 2024
@joshlf
Make extend_vec_zeroed, insert_vec_zeroed fallible
21d63a2 
They now return `AllocError` on allocation failure. `insert_vec_zeroed`
still panics if its `position` argument is out-of-bounds.

This requires using `Vec::try_reserve`, which is unstable before 1.57.0.
Since our MSRV is currently 1.56.0, these functions are now
conditionally compiled and only available on 1.57.0 and later.

Closes #1653
github-merge-queue bot pushed a commit that referenced this issue Sep 15, 2024
@joshlf
Make extend_vec_zeroed, insert_vec_zeroed fallible (#1658)
0003184 
They now return `AllocError` on allocation failure. `insert_vec_zeroed`
still panics if its `position` argument is out-of-bounds.

This requires using `Vec::try_reserve`, which is unstable before 1.57.0.
Since our MSRV is currently 1.56.0, these functions are now
conditionally compiled and only available on 1.57.0 and later.

Closes #1653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking-next-release This issue should be resolved before we release on crates.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make extend_vec_zeroed, insert_vec_zeroed fallible google/zerocopy
1 participant
@joshlf